Skip to content

Fix for spatial preconditioners in generic spectral problem class #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

Fix for spatial preconditioners in generic spectral problem class #568

merged 2 commits into from
Jul 11, 2025

Conversation

@brownbaerchen
Copy link
Contributor

@brownbaerchen brownbaerchen commented Jul 11, 2025

This PR has a few small things:

  • There was a bug in the Dirichlet recombination (right preconditioner), which was never done
  • Initial guesses are now correctly treated for the right preconditioner
  • A few small tests including that the system matrices are actually banded once preconditioned

@tlunet
Copy link
Member

tlunet commented Jul 11, 2025

Looks good to me, ok to merge as soon as the test pass

@pancetta pancetta merged commit 4e2ce4d into Parallel-in-Time:master Jul 11, 2025
47 checks passed
@brownbaerchen brownbaerchen deleted the preconditioner_fix branch July 11, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brownbaerchen @tlunet @pancetta